Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation in a macOS GitHub runner fails with cc v1.0.84 #8820

Closed
zydou opened this issue Nov 15, 2023 · 0 comments · Fixed by #9548
Closed

Compilation in a macOS GitHub runner fails with cc v1.0.84 #8820

zydou opened this issue Nov 15, 2023 · 0 comments · Fixed by #9548
Labels
A-dependencies Area: Dependency C-bug Category: This is a bug rust Pull requests that update Rust code upstream

Comments

@zydou
Copy link

zydou commented Nov 15, 2023

40959bb bumps cc to v1.0.84. However, this release has a problem that causes the build on macOS to fail.

upstream issue: rust-lang/cc-rs#900
fail logs: https://github.com/zydou/helix/actions/runs/6870927003/job/18689481341

This release has been yanked on the release page:

This release has been yanked, due to the Apple deployment target changes causing unintentional widespread breakage for building C++ code on the target (for projects without an explicit deployment target set). A release without these issues will be made in the near future.
Sorry, and thanks.
@the-mikedavis the-mikedavis added C-bug Category: This is a bug A-dependencies Area: Dependency rust Pull requests that update Rust code upstream labels Nov 15, 2023
@pashadia pashadia mentioned this issue Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-dependencies Area: Dependency C-bug Category: This is a bug rust Pull requests that update Rust code upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "build(deps): bump cc from 1.0.83 to 1.0.84 (#8809)" pashadia/helix
2 participants
@the-mikedavis @zydou