Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review stretch_driver's use of executor and callback groups #161

Open
2 of 4 tasks
hello-binit opened this issue Aug 27, 2024 · 0 comments
Open
2 of 4 tasks

Review stretch_driver's use of executor and callback groups #161

hello-binit opened this issue Aug 27, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@hello-binit
Copy link
Contributor

hello-binit commented Aug 27, 2024

Stretch Driver is currently configured to use the MultiThreadedExecutor, with a single MutuallyExclusiveCallbackGroup shared among all the callbacks. This is effectively a SingleThreadedExecutor. To solve this issue,

  • Review the state of Stretch Driver's callback groups, ensuring the callbacks are running in the most efficient way possible, and that no deadlocks are possible. A great guide on the subject of ROS2 executors and callback groups can be found here.
  • Confirm whether all of the callbacks are matched to a single group, or if there is a hidden group.
  • Run tests to verify that callbacks that are expected to run in parallel actually do.
  • Write docs that document the design decisions for this node.
@hello-binit hello-binit added the documentation Improvements or additions to documentation label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant