Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving the binary testdata/https-request/https-request with git will increase the size of repository #249

Open
Laitr0n opened this issue Jan 5, 2025 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Laitr0n
Copy link
Contributor

Laitr0n commented Jan 5, 2025

Describe the bug
The binary file testdata/https-request/https-request is currently saved directly in Git. Frequent updates to this binary will cause the repository size to grow progressively larger, potentially leading to performance issues.

To Reproduce
Same as described above.

Expected behavior
The binary file should be managed using Git LFS to prevent excessive growth in repository size.

Screenshots
None.

Information (please complete the following information):
None.

@dosubot dosubot bot added the bug Something isn't working label Jan 5, 2025
@hengyoush
Copy link
Owner

Thanks for the suggestions. Are you willing to send a PR for this?

@hengyoush hengyoush added enhancement New feature or request and removed bug Something isn't working labels Jan 5, 2025
@Laitr0n
Copy link
Contributor Author

Laitr0n commented Jan 6, 2025

Sure. Assign to me.

@Laitr0n
Copy link
Contributor Author

Laitr0n commented Jan 8, 2025

Hi @hengyoush,

I’ve encountered a couple of issues while working on migrating the file to LFS:

  1. GitHub does not support pushing LFS objects to forked repositories
    According to the GitHub documentation, LFS objects cannot be pushed to forks. To migrate files to LFS successfully, write access to the upstream repository will be necessary to store the LFS objects properly.

  2. Tracking files does not retroactively convert them to LFS
    Simply tracking files in LFS does not convert existing files that are already part of the repository's history. The only way to migrate old files is by rewriting the commit history, as outlined in the Git LFS migration tutorial.
    This process is intrusive, as it modifies the commit history. Is this approach acceptable? If so, I may need to further familiarize myself with the procedure or collaborate with someone experienced in LFS migrations for public repositories.

If you have any opinion, please let me know.

@hengyoush
Copy link
Owner

Thanks a lot for the detailed analysis and write up.

Looks like write access to the repository is needed. I will follow up on this later.

@hengyoush hengyoush assigned hengyoush and unassigned Laitr0n Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants