Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up to devDependencies change #524

Open
jmorrell opened this issue Mar 1, 2018 · 0 comments
Open

Follow-up to devDependencies change #524

jmorrell opened this issue Mar 1, 2018 · 0 comments
Labels
needs investigation

Comments

@jmorrell
Copy link
Contributor

jmorrell commented Mar 1, 2018

From @edmorley:

  • Does warn_missing_devdeps in failure.sh need updating to also check for YARN_PRODUCTION?
  • Can the NPM_CONFIG_PRODUCTION export now be removed from bin/test-compile?
  • In environment.sh's list_node_config, should the mcount "npm-config-production-true" also include YARN_PRODUCTION (or a new count be added)?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmorrell @danielleadams