fix(firewall): missing error when not setting port for tcp rule #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phm07
force-pushed
the
fix-firewall-add-rule-error
branch
from
aa1328e
to
93307aa
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #734 +/- ##
==========================================
+ Coverage 59.92% 59.94% +0.01%
==========================================
Files 180 180
Lines 6511 6509 -2
==========================================
Hits 3902 3902
+ Misses 1991 1987 -4
- Partials 618 620 +2 ☔ View full report in Codecov by Sentry. |
jooola
approved these changes
Apr 19, 2024
apricote
pushed a commit
that referenced
this pull request
Apr 22, 2024
🤖 I have created a release *beep* *boop* --- ## [1.43.1](v1.43.0...v1.43.1) (2024-04-19) ### Bug Fixes * allow passing multiple args to server ssh command ([#729](#729)) ([d98aee5](d98aee5)), closes [#728](#728) * creating firewall with rules not working correctly ([64aeb23](64aeb23)) * **firewall:** missing error when not setting port for tcp rule ([#734](#734)) ([c5ad470](c5ad470)) * **firewall:** setting rules not working correctly ([da1b684](da1b684)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch cases don't fall through by default in Go, which lead to there being no user-friendly error emitted when the user attempts to create a TCP rule without specifying a port.
Related to #733