Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve datacenter describe server types readability #854

Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Aug 27, 2024

Closes #852

@jooola jooola requested a review from a team as a code owner August 27, 2024 19:46
@jooola jooola requested a review from phm07 August 27, 2024 19:46
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.49%. Comparing base (2df45e0) to head (d06bff9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/datacenter/describe.go 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
+ Coverage   61.47%   61.49%   +0.02%     
==========================================
  Files         238      238              
  Lines        8511     8522      +11     
==========================================
+ Hits         5232     5241       +9     
- Misses       2571     2572       +1     
- Partials      708      709       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally preferred the table output from the issue, but this is already way better than the current solution, so I am happy about the improvement in general!

internal/cmd/datacenter/describe_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@phm07 phm07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jooola jooola merged commit fc0002c into main Aug 30, 2024
5 checks passed
@jooola jooola deleted the feat--improve-datacenter-describe-server-types-readability branch August 30, 2024 10:51
phm07 pushed a commit that referenced this pull request Aug 30, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.47.0](v1.46.0...v1.47.0)
(2024-08-30)


### Features

* allow deleting rDNS entries
([#839](#839))
([129f51d](129f51d)),
closes [#814](#814)
* **certificate:** allow retrying managed certificate issuance
([#847](#847))
([0223f7d](0223f7d))
* improve datacenter describe server types readability
([#854](#854))
([fc0002c](fc0002c)),
closes [#852](#852)


### Bug Fixes

* `quiet` option sometimes only working as a flag
([#846](#846))
([f7c9ac6](f7c9ac6))
* **image:** only accept numerical ids for update, delete, label
([#844](#844))
([7355571](7355571))
* **load-balancer:** show message if none of --server, --label-selector
or --ip is set ([#849](#849))
([2df45e0](2df45e0))
* **primary-ip:** change protection commands do not allow protection
levels ([#851](#851))
([697a87a](697a87a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve server types readability for datacenter describe command
3 participants