From 7aa995c947924f2fb668eff137a3197291a54634 Mon Sep 17 00:00:00 2001
From: Hernan Grecco <hgrecco@gmail.com>
Date: Sat, 2 Dec 2023 23:51:18 -0300
Subject: [PATCH] Add a conversion factor cache

---
 pint/facets/context/registry.py |  1 +
 pint/facets/plain/registry.py   | 56 ++++++++++++++++++++++++++-------
 2 files changed, 46 insertions(+), 11 deletions(-)

diff --git a/pint/facets/context/registry.py b/pint/facets/context/registry.py
index 85682d198..3bfb3fd25 100644
--- a/pint/facets/context/registry.py
+++ b/pint/facets/context/registry.py
@@ -35,6 +35,7 @@ def __init__(self, registry_cache) -> None:
         self.root_units = {}
         self.dimensionality = registry_cache.dimensionality
         self.parse_unit = registry_cache.parse_unit
+        self.conversion_factor = {}
 
 
 class GenericContextRegistry(
diff --git a/pint/facets/plain/registry.py b/pint/facets/plain/registry.py
index f71cdf791..420179408 100644
--- a/pint/facets/plain/registry.py
+++ b/pint/facets/plain/registry.py
@@ -131,6 +131,10 @@ def __init__(self) -> None:
         #: Cache the unit name associated to user input. ('mV' -> 'millivolt')
         self.parse_unit: dict[str, UnitsContainer] = {}
 
+        self.conversion_factor: dict[
+            tuple[UnitsContainer, UnitsContainer], Scalar | DimensionalityError
+        ] = {}
+
     def __eq__(self, other: Any):
         if not isinstance(other, self.__class__):
             return False
@@ -139,6 +143,7 @@ def __eq__(self, other: Any):
             "root_units",
             "dimensionality",
             "parse_unit",
+            "conversion_factor",
         )
         return all(getattr(self, attr) == getattr(other, attr) for attr in attrs)
 
@@ -801,6 +806,43 @@ def get_root_units(
 
         return f, self.Unit(units)
 
+    def _get_conversion_factor(
+        self, src: UnitsContainer, dst: UnitsContainer
+    ) -> Scalar | DimensionalityError:
+        """Get conversion factor in non-multiplicative units.
+
+        Parameters
+        ----------
+        src
+            Source units
+        dst
+            Target units
+
+        Returns
+        -------
+            Conversion factor or DimensionalityError
+        """
+        cache = self._cache.conversion_factor
+        try:
+            return cache[(src, dst)]
+        except KeyError:
+            pass
+
+        src_dim = self._get_dimensionality(src)
+        dst_dim = self._get_dimensionality(dst)
+
+        # If the source and destination dimensionality are different,
+        # then the conversion cannot be performed.
+        if src_dim != dst_dim:
+            return DimensionalityError(src, dst, src_dim, dst_dim)
+
+        # Here src and dst have only multiplicative units left. Thus we can
+        # convert with a factor.
+        factor, _ = self._get_root_units(src / dst)
+
+        cache[(src, dst)] = factor
+        return factor
+
     def _get_root_units(
         self, input_units: UnitsContainer, check_nonmult: bool = True
     ) -> tuple[Scalar, UnitsContainer]:
@@ -1015,18 +1057,10 @@ def _convert(
 
         """
 
-        if check_dimensionality:
-            src_dim = self._get_dimensionality(src)
-            dst_dim = self._get_dimensionality(dst)
-
-            # If the source and destination dimensionality are different,
-            # then the conversion cannot be performed.
-            if src_dim != dst_dim:
-                raise DimensionalityError(src, dst, src_dim, dst_dim)
+        factor = self._get_conversion_factor(src, dst)
 
-        # Here src and dst have only multiplicative units left. Thus we can
-        # convert with a factor.
-        factor, _ = self._get_root_units(src / dst)
+        if isinstance(factor, DimensionalityError):
+            raise factor
 
         # factor is type float and if our magnitude is type Decimal then
         # must first convert to Decimal before we can '*' the values