Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

增强用于匹配INSER语句的正则 #1944

Merged
merged 1 commit into from
Oct 26, 2022
Merged

增强用于匹配INSER语句的正则 #1944

merged 1 commit into from
Oct 26, 2022

Conversation

allen12921
Copy link
Contributor

  • 现有正则无法从下列语句获取正确的table_name(实际是无法匹配大部分格式化后的语句)
insert into
  db.newtable(
    account_id,
    application_id,
    customer_id,
    created_at
  )
select
  account_id,
  application_id,
  customer_id,
  created_at
from
  old_table;
  • 更改后的正则更简单,高效并能保证table_name严格符合数据库表命名规则

@allen12921
增强用于匹配INSER语句的正则
652268d 
* 现有正则无法从下列语句获取正确的table_name(实际是无法匹配大部分格式化后的语句)
insert into
  db.newtable(
    account_id,
    application_id,
    customer_id,
    created_at
  )
select
  account_id,
  application_id,
  customer_id,
  created_at
from
  old_table;
* 更改后的正则更简单,高效并能保证table_name严格符合数据库表命名规则
@codecov
Copy link

codecov bot commented Oct 26, 2022 •
edited
Loading

Codecov Report

Base: 75.91% // Head: 75.91% // No change to project coverage 👍

Coverage data is based on head (652268d) compared to base (029ebab).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1944   +/-   ##
=======================================
  Coverage   75.91%   75.91%           
=======================================
  Files          91       91           
  Lines       14203    14203           
=======================================
  Hits        10782    10782           
  Misses       3421     3421
Impacted Files Coverage Δ
sql/engines/clickhouse.py 71.48% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hhyo hhyo merged commit 3ff5c95 into hhyo:master Oct 26, 2022
nick2wang pushed a commit to nick2wang/Archery that referenced this pull request Nov 8, 2022
@allen12921 @nick2wang
增强用于匹配INSER语句的正则 (hhyo#1944)
f43f4fa 
* 现有正则无法从下列语句获取正确的table_name(实际是无法匹配大部分格式化后的语句)
insert into
  db.newtable(
    account_id,
    application_id,
    customer_id,
    created_at
  )
select
  account_id,
  application_id,
  customer_id,
  created_at
from
  old_table;
* 更改后的正则更简单,高效并能保证table_name严格符合数据库表命名规则

(cherry picked from commit 3ff5c95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick2wang nick2wang nick2wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allen12921 @nick2wang @hhyo