Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复mongo正则匹配与method取值问题 #1973

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

nick2wang
Copy link
Collaborator

处理两个遗留问题:

  1. pr 问题:mongodb表名带-和.符号无法申请上线,原因:\w只匹配[a-zA-Z0-9_],修正:(\w*) -> ([\w\.-]+) #1372 这里对集合名包含特殊符号做了兼容,但是db.getCollection的正则当时没有更新到
    01

  2. pr 问题: mongodb表名带多个.的情况下, 无法正确截取methodStr. 原因是 默认截取第二个 "." 到"(" 之间的字符串作为method #1381 取method注释描述是对的,但是split顺序反了,导致诸如db.getCollection("abc").remove({})、db.abc.find({}).remove()的语句都无法提交
    02

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 75.94% // Head: 75.94% // No change to project coverage 👍

Coverage data is based on head (05a7320) compared to base (287e74a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1973   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files          91       91           
  Lines       14319    14319           
=======================================
  Hits        10875    10875           
  Misses       3444     3444           
Impacted Files Coverage Δ
sql/engines/mongo.py 49.79% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hhyo hhyo merged commit d719a14 into hhyo:master Nov 23, 2022
@nick2wang nick2wang deleted the fix-mongo-match-bug branch November 24, 2022 01:13
nick2wang added a commit to nick2wang/Archery that referenced this pull request Dec 6, 2022
Co-authored-by: 小圈圈 <[email protected]>
(cherry picked from commit d719a14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants