新增sql执行行数限制 #2366
Merged
新增sql执行行数限制 #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
格式化代码
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2366 +/- ##
==========================================
- Coverage 75.99% 75.99% -0.01%
==========================================
Files 111 111
Lines 15749 15752 +3
==========================================
+ Hits 11968 11970 +2
- Misses 3781 3782 +1
☔ View full report in Codecov by Sentry. |
LeoQuote
reviewed
Nov 6, 2023
| @@ -69,6 +69,11 @@ def post(self, request): | |||
| check_result = check_engine.execute_check( | |||
| db_name=db_name, sql=request.data["full_sql"].strip() | |||
| ) | |||
| max_sql_length = SysConfig().get("max_sql_length", default_value=10000) | |||
| if len(check_result.rows) > int(max_sql_length): | |||
|
建议默认配置0不做限制，新加参数都尽量不改变前序版本的逻辑 其实30m左右的语句应该都没什么影响，卡死可以找找其他原因 |
|
好的，已经修改 |
Closed
finovy
pushed a commit
to finovy/Archery
that referenced
this pull request
Nov 10, 2023
* 新增cas登录 * 新增cas登录 * 新增cas登录 * 新增cas登录 * 新增cas登录 * black格式化 * 修改模块引用错误 * 修改模块引用错误 * 修改模块引用错误 * 新增最大SQL提交数 * Update mssql.py 格式化代码 * black 代码 --------- Co-authored-by: lanjiaxuan <[email protected]>
Merged
LeoQuote
added a commit
that referenced
this pull request
Nov 16, 2023
finovy
pushed a commit
to finovy/Archery
that referenced
this pull request
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2365
新增sql执行行数限制