Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NativeClass.name error / could remove dep on mongoskin? #12

Open
dcsan opened this issue Feb 18, 2016 · 3 comments
Open

NativeClass.name error / could remove dep on mongoskin? #12

dcsan opened this issue Feb 18, 2016 · 3 comments
Labels

Comments

@dcsan
Copy link

dcsan commented Feb 18, 2016

I hit this error on trying to run your example

/Users/dc/dev/rikai/chateditor/botkit-express/node_modules/mongoskin/lib/utils.js:33
  var skinClassName = 'Skin' + NativeClass.name;
                                          ^

TypeError: Cannot read property 'name' of undefined
    at makeSkinClass (/Users/dc/dev/rikai/chateditor/botkit-express/node_modules/mongoskin/lib/utils.js:33:43)
    at Object.<anonymous> (/Users/dc/dev/rikai/chateditor/botkit-express/node_modules/mongoskin/lib/grid.js:6:35)

robe uses monk which depends on mongoskin, which is not maintained and has some issues?
kissjs/node-mongoskin#153

https://github.com/Automattic/monk/graphs/contributors

Since the native mongo driver now has promises, could robe be written to remove this house of cards of dependencies?

seems i now need to dig deep into the dependency chain to downgrade a dep... which seems fragile if it will even work at all.

@dcsan
Copy link
Author

dcsan commented Feb 18, 2016

node v5.6

npm list robe
[email protected] /Users/dc/dev/rikai/chateditor/botkit-express
└─┬ [email protected] 
  └── UNMET PEER DEPENDENCY [email protected]

npm ERR! peer dep missing: mongodb@~1.4, required by [email protected]

so i uninstalled and reinstalled, but still the same problem

  botkit-express git:(master) ✗ npm install robe

> [email protected] install /Users/dc/dev/rikai/chateditor/botkit-express/node_modules/kerberos
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/kerberos/lib/kerberos.o

> [email protected] install /Users/dc/dev/rikai/chateditor/botkit-express/node_modules/robe/node_modules/monk/node_modules/kerberos
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/kerberos/lib/kerberos.o

> [email protected] install /Users/dc/dev/rikai/chateditor/botkit-express/node_modules/robe/node_modules/monk/node_modules/bson
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/bson/ext/bson.o

> [email protected] install /Users/dc/dev/rikai/chateditor/botkit-express/node_modules/robe/node_modules/bson
> (node-gyp rebuild 2> builderror.log) || (exit 0)

  CXX(target) Release/obj.target/bson/ext/bson.o
[email protected] /Users/dc/dev/rikai/chateditor/botkit-express
├─┬ [email protected]
│ ├─┬ [email protected]
│ │ ├─┬ [email protected]
│ │ │ └── [email protected] 
│ │ ├─┬ [email protected]
│ │ │ └── [email protected] 
│ │ ├─┬ [email protected]
│ │ │ └── [email protected] 
│ │ ├─┬ [email protected]
│ │ │ └── [email protected] 
│ │ └── [email protected] 
│ ├─┬ [email protected]
│ │ └── [email protected] 
│ ├─┬ [email protected]
│ │ ├─┬ [email protected]
│ │ │ └─┬ [email protected]
│ │ │   └─┬ [email protected]
│ │ │     └── [email protected] 
│ │ └─┬ [email protected]
│ │   └── [email protected] 
│ └── [email protected] 
├─┬ [email protected]
│ └─┬ [email protected]
│   └─┬ [email protected]
│     └── [email protected] 
├─┬ [email protected] 
│ ├─┬ [email protected]
│ │ └─┬ [email protected]
│ │   └─┬ [email protected]
│ │     └─┬ [email protected]
│ │       └── [email protected] 
│ └─┬ [email protected]
│   └─┬ [email protected]
│     ├─┬ [email protected]
│     │ └─┬ [email protected]
│     │   └── [email protected] 
│     ├─┬ [email protected]
│     │ └─┬ [email protected]
│     │   └── [email protected] 
│     └─┬ [email protected]
│       └── [email protected] 
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected] 
└─┬ [email protected] 
  ├── [email protected] 
  ├── [email protected] 
  ├── [email protected] 
  ├── [email protected] 
  ├── [email protected] 
  ├─┬ UNMET PEER DEPENDENCY [email protected]
  │ ├─┬ [email protected] 
  │ │ └── [email protected] 
  │ ├─┬ [email protected] 
  │ │ └── [email protected] 
  │ └── [email protected] 
  ├── [email protected] 
  ├─┬ [email protected] 
  │ └─┬ [email protected] 
  │   └─┬ [email protected] 
  │     ├─┬ [email protected] 
  │     │ └── [email protected] 
  │     └── [email protected] 
  └── [email protected] 

npm WARN [email protected] requires a peer of mongodb@~1.4 but none was installed.
npm WARN [email protected] No repository field.
➜  botkit-express git:(master) ✗ npm list robe
[email protected] /Users/dc/dev/rikai/chateditor/botkit-express
└─┬ [email protected] 
  └── UNMET PEER DEPENDENCY [email protected]

npm ERR! peer dep missing: mongodb@~1.4, required by [email protected]

@dcsan
Copy link
Author

dcsan commented Feb 18, 2016

ok manually installing per this issue

Automattic/monk#114

➜  botkit-express git:(master) ✗ npm list mongodb
[email protected] /Users/dc/dev/rikai/chateditor/botkit-express
├── [email protected] 
├─┬ [email protected]
│ └── [email protected] 
├─┬ [email protected]
│ └─┬ [email protected]
│   └── [email protected] 
└─┬ [email protected]
  ├── [email protected] 
  └─┬ [email protected]
    └─┬ [email protected]
      └── [email protected] 

➜  botkit-express git:(master) ✗ npm list robe   
[email protected] /Users/dc/dev/rikai/chateditor/botkit-express
└── [email protected] 

@hiddentao
Copy link
Owner

Glad that worked out for you. - yeah, at some point it would be good to rewrite Robe accordingly.

@hiddentao hiddentao added the bug label Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants