Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bip39 passphrase must be normalized #1334

Closed
nikola-genov opened this issue Nov 25, 2022 · 0 comments · Fixed by #1335
Closed

Bip39 passphrase must be normalized #1334

nikola-genov opened this issue Nov 25, 2022 · 0 comments · Fixed by #1335
Assignees
@petreze
Labels
bug Something isn't working
Milestone
2.19.0

Comments

@nikola-genov
Copy link

Description

Current implementation allows any unicode string as a passphrase, but the BIP39 spec states that it must be normalized to NFKD

Steps to reproduce

n/a

Additional context

Related issue in java-sdk - 1240

Hedera network

mainnet

Version

any

Operating system

No response
@nikola-genov nikola-genov added the bug Something isn't working label Nov 25, 2022
@petreze petreze self-assigned this Nov 25, 2022
@petreze petreze mentioned this issue Nov 25, 2022
Merged
2 tasks
@ochikov ochikov added this to the 2.19.0 milestone Nov 28, 2022
@Petyo-Lukanov Petyo-Lukanov modified the milestone: 2.19.0 Nov 28, 2022
@ochikov ochikov mentioned this issue Dec 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petreze petreze

Labels
bug Something isn't working
Projects
None yet
Milestone
2.19.0
Development

Successfully merging a pull request may close this issue.

Аdded NFKD normalization for mnemonic passphrase hiero-ledger/hiero-sdk-js
4 participants
@ochikov @petreze @Petyo-Lukanov @nikola-genov