Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientConstants.js missing entries #1745

Closed
gregscullard opened this issue Jul 31, 2023 · 1 comment · Fixed by #1780
Closed

ClientConstants.js missing entries #1745

gregscullard opened this issue Jul 31, 2023 · 1 comment · Fixed by #1780
Assignees
Labels
bug Something isn't working
Milestone

Comments

@gregscullard
Copy link
Contributor

Description

A transaction generated by a node.js backend fails to be processed by a wallet with an 'invalid node account id' error.
The transaction specified node account id 0.0.18 which is a valid consensus node, however the ClientConstants.js doesn't have an entry for this node accountId, it goes from 17 to 19, skipping 18 altogether

https://github.com/hashgraph/hedera-sdk-js/blob/develop/src/constants/ClientConstants.js

    "https://node14.swirldslabs.com:443": new AccountId(17),
    "https://node16.swirldslabs.com:443": new AccountId(19),

Also note that the list of consensus nodes https://docs.hedera.com/hedera/networks/mainnet/mainnet-nodes goes up to node account id 0.0.31, the constants file stops at 0.0.29.

Steps to reproduce

Generate a transaction which specifies account id 0.0.18 for the node_account_id, attempt to sign and execute the transaction in a web client, it will fail.

Additional context

No response

Hedera network

mainnet

Version

2.29

Operating system

None

@SimiHunjan
Copy link
Contributor

Noting here that 0.0.31 and 0.0.30 do not currently have a gRPC web proxy set up. Once this service is available we will add them to the SDKs. DevOps will note when available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants