Fix bsize bug #165
Merged
Fix bsize bug #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boris-de
force-pushed
the
fix_bsize_bug
branch
from
52748cd to
63ec6a9
Compare
The implementation of BaseMac would only take the bsize (size of the hash) into account if the #doFinal(byte[], int) method was called. Both other #doFinal methods would behave as if bsize==defbsize and not cut the hash to the right size.
Boris-de
force-pushed
the
fix_bsize_bug
branch
from
63ec6a9 to
73de5b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of BaseMac would only take the bsize (size of the hash) into account if the #doFinal(byte[], int) method was called. Both other #doFinal methods would behave as if bsize==defbsize and not cut the hash to the right size.
This doesn't seem to be a problem right now because the #doFinal() seems to be entirely unused and #doFinal(byte[]) is only used by OpenSSHKnownHosts which always uses HMACSHA1 (with the default hash-size).
This PR depends on #164