Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsloth supports dora now! #2666

Closed
1 task done
kostum123 opened this issue Mar 1, 2024 · 5 comments
Closed
1 task done

Unsloth supports dora now! #2666

kostum123 opened this issue Mar 1, 2024 · 5 comments
Labels
solved This problem has been already solved

Comments

@kostum123
Copy link

Reminder

  • I have read the README and searched the existing issues.

Reproduction

Unsloth supports Dora with the new update. I recommend that you remove the code in your software that prevents activating the dora setting.

Expected behavior

No response

System Info

No response

Others

No response
@hiyouga
Copy link
Owner

hiyouga commented Mar 2, 2024 •
edited
Loading

I can not find any evidence that unsloth supports dora in their source code, could you provide one?

@hiyouga hiyouga added pending This problem is yet to be addressed invalid This doesn't seem right and removed pending This problem is yet to be addressed labels Mar 2, 2024
@hiyouga hiyouga closed this as completed Mar 4, 2024
@letterk
Copy link

letterk commented Jun 10, 2024 •
edited
Loading

https://github.com/unslothai/unsloth/issues/182
已经支持Dora了，我在油管上也见过有博主用dora和unsloth一起跑
@hiyouga

@hiyouga hiyouga added solved This problem has been already solved and removed invalid This doesn't seem right labels Jun 10, 2024
hiyouga added a commit that referenced this issue Jun 10, 2024
@hiyouga
fix #2666
c907d81
@hiyouga
Copy link
Owner

hiyouga commented Jun 10, 2024

@letterk fixed

@letterk
Copy link

letterk commented Jun 11, 2024

LLaMA-Factory/src/llamafactory/hparams/parser.py

Lines 174 to 175 in 796699f

if finetuning_args.use_dora and model_args.use_unsloth:
raise ValueError("Unsloth does not support DoRA.")

还遗漏了一个地方@hiyouga

@hiyouga
Copy link
Owner

hiyouga commented Jun 11, 2024 •
edited
Loading

@letterk fixed, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@letterk @hiyouga @kostum123