Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llama3 template issue #3352

Closed
1 task done
JianbangZ opened this issue Apr 19, 2024 · 1 comment
Closed
1 task done

llama3 template issue #3352

JianbangZ opened this issue Apr 19, 2024 · 1 comment
Labels
solved This problem has been already solved

Comments

@JianbangZ
Copy link

Reminder

  • I have read the README and searched the existing issues.

Reproduction

shouldn't we use following format_system for the "llama3" template?
format_system=StringFormatter(slots=[{"bos_token"}, "<|start_header_id|>system<|end_header_id|>\n\n{{content}}<|eot_id|>"])

Expected behavior

No response

System Info

No response

Others

No response
@JianbangZ JianbangZ changed the title llama3 tempalate issue llama3 template issue Apr 19, 2024
@hiyouga
Copy link
Owner

hiyouga commented Apr 19, 2024

fixed

@hiyouga hiyouga added the solved This problem has been already solved label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JianbangZ @hiyouga