Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] pissa init脚本报错 #4556

Closed
1 task done
letterk opened this issue Jun 26, 2024 · 1 comment
Closed
1 task done

[bug] pissa init脚本报错 #4556

letterk opened this issue Jun 26, 2024 · 1 comment
Labels
solved This problem has been already solved

Comments

@letterk
Copy link

letterk commented Jun 26, 2024

Reminder

  • I have read the README and searched the existing issues.

System Info

  • llamafactory version: 0.8.3.dev0
  • Platform: Linux-5.15.146.1-microsoft-standard-WSL2-x86_64-with-glibc2.35
  • Python version: 3.11.9
  • PyTorch version: 2.3.0+cu121 (GPU)
  • Transformers version: 4.41.2
  • Datasets version: 2.20.0
  • Accelerate version: 0.31.0
  • PEFT version: 0.11.1
  • TRL version: 0.8.6
  • GPU type: NVIDIA GeForce RTX 4060 Ti
  • Bitsandbytes version: 0.43.1

Reproduction

python pissa_init.py ~/WORKDIR/hf/Qwen2-7B-Instruct ~/WORKDIR/saves/Qwen2-7B/pissa/sft -p 16 --lora_rank 32 --lora_target 'k_proj,o_proj,q_proj,v_proj,down_proj,gate_proj,up_proj'
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
`low_cpu_mem_usage` was None, now set to True since model is quantized.
Traceback (most recent call last):
  File "/home/kissoul/WORKDIR/LLaMA-Factory/scripts/pissa_init.py", line 83, in <module>
    fire.Fire(quantize_pissa)
  File "/home/kissoul/miniconda3/envs/lf/lib/python3.11/site-packages/fire/core.py", line 143, in Fire
    component_trace = _Fire(component, args, parsed_flag_args, context, name)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kissoul/miniconda3/envs/lf/lib/python3.11/site-packages/fire/core.py", line 477, in _Fire
    component, remaining_args = _CallAndUpdateTrace(
                                ^^^^^^^^^^^^^^^^^^^^
  File "/home/kissoul/miniconda3/envs/lf/lib/python3.11/site-packages/fire/core.py", line 693, in _CallAndUpdateTrace
    component = fn(*varargs, **kwargs)
                ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/kissoul/WORKDIR/LLaMA-Factory/scripts/pissa_init.py", line 53, in quantize_pissa
    target_modules=[name.strip() for name in lora_target.split(",")],
                                             ^^^^^^^^^^^^^^^^^
AttributeError: 'tuple' object has no attribute 'split'

打印出来确实传递成元组了
lora_target value before function call: ('k_proj', 'o_proj', 'q_proj', 'v_proj', 'down_proj', 'gate_proj', 'up_proj'), type: <class 'tuple'>

Expected behavior

No response

Others

No response

@github-actions github-actions bot added the pending This problem is yet to be addressed label Jun 26, 2024
@hiyouga
Copy link
Owner

hiyouga commented Jun 26, 2024

--lora_target '"k_proj,o_proj,q_proj,v_proj,down_proj,gate_proj,up_proj"'

@hiyouga hiyouga added solved This problem has been already solved and removed pending This problem is yet to be addressed labels Jun 26, 2024
PrimaLuz pushed a commit to PrimaLuz/LLaMA-Factory that referenced this issue Jul 1, 2024
xtchen96 pushed a commit to xtchen96/LLaMA-Factory that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

No branches or pull requests

2 participants