Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: is Adam-mini optimizer worth adding? #4696

Closed
1 task done
jim-plus opened this issue Jul 5, 2024 · 0 comments
Closed
1 task done

Feature request: is Adam-mini optimizer worth adding? #4696

jim-plus opened this issue Jul 5, 2024 · 0 comments
Labels
solved This problem has been already solved

Comments

@jim-plus
Copy link

jim-plus commented Jul 5, 2024

Reminder

  • I have read the README and searched the existing issues.

System Info

N/A

Reproduction

N/A

Expected behavior

Consideration of Adam-mini optimizer, which claims to be able to significantly boost throughput for both training and pretraining while reducing memory consumption.
https://arxiv.org/abs/2406.16793

Others

No response
@github-actions github-actions bot added the pending This problem is yet to be addressed label Jul 5, 2024
@jim-plus jim-plus changed the title Feature request: is adam-mini worth adding? Feature request: is Adam-mini optimizer worth adding? Jul 5, 2024
@relic-yuexi relic-yuexi mentioned this issue Aug 7, 2024
Merged
1 task
@hiyouga hiyouga added solved This problem has been already solved and removed pending This problem is yet to be addressed labels Aug 9, 2024
@hiyouga hiyouga closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jim-plus @hiyouga