Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Yaml File for Full Predict #5092

Closed
1 task done
maksimstw opened this issue Aug 6, 2024 · 1 comment · Fixed by #5109
Closed
1 task done

Deprecated Yaml File for Full Predict #5092

maksimstw opened this issue Aug 6, 2024 · 1 comment · Fixed by #5109
Labels
solved This problem has been already solved

Comments

@maksimstw
Copy link

Reminder

  • I have read the README and searched the existing issues.

System Info

llamafactory 0.8.3

Reproduction

New version of llamafactory forces users to specify an evaluation dataset when do_predict is true. This makes the example yaml file no longer works. Downgrading llamfactory to 0.8.1 works.

Command

llamafactory-cli train example/train_full/llama3_full_predict.yaml

Error Message

Traceback (most recent call last):
File "/opt/conda/envs/ptca/lib/python3.10/site-packages/llamafactory/launcher.py", line 23, in
launch()
File "/opt/conda/envs/ptca/lib/python3.10/site-packages/llamafactory/launcher.py", line 19, in launch
run_exp()
File "/opt/conda/envs/ptca/lib/python3.10/site-packages/llamafactory/train/tuner.py", line 45, in run_exp
model_args, data_args, training_args, finetuning_args, generating_args = get_train_args(args)
File "/opt/conda/envs/ptca/lib/python3.10/site-packages/llamafactory/hparams/parser.py", line 209, in get_train_args
raise ValueError("Please specify dataset for evaluation.")
ValueError: Please specify dataset for evaluation

Expected behavior

No response

Others

No response

@github-actions github-actions bot added the pending This problem is yet to be addressed label Aug 6, 2024
@codemayq
Copy link
Collaborator

codemayq commented Aug 7, 2024

fixed

@codemayq codemayq added solved This problem has been already solved and removed pending This problem is yet to be addressed labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants