Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please upgrade accelerate requirement to version 0.33.0 #5295

Closed
1 task done
FlowRays opened this issue Aug 28, 2024 · 1 comment
Closed
1 task done

Please upgrade accelerate requirement to version 0.33.0 #5295

FlowRays opened this issue Aug 28, 2024 · 1 comment
Labels
solved This problem has been already solved

Comments

@FlowRays
Copy link

Reminder

  • I have read the README and searched the existing issues.

System Info

  • llamafactory version: 0.8.4.dev0
  • Platform: Linux-5.4.0-146-generic-x86_64-with-glibc2.27
  • Python version: 3.11.9
  • PyTorch version: 2.4.0+cu121 (GPU)
  • Transformers version: 4.43.4
  • Datasets version: 2.20.0
  • Accelerate version: 0.32.0
  • PEFT version: 0.12.0
  • TRL version: 0.9.6
  • GPU type: NVIDIA A100-PCIE-40GB
  • DeepSpeed version: 0.15.0
  • Bitsandbytes version: 0.43.3
  • vLLM version: 0.5.5

Reproduction

In the current highest supported version of accelerate (0.32.0), loading the 7B model with the following code in my environment results in a speed of "Loading checkpoint shards 00:30, 7.63s/it". However, in version 0.33.0 of accelerate, the loading speed is "Loading checkpoint shards 00:04, 1.14s/it".

model = AutoModelForCausalLM.from_pretrained(model_name)

Additionally, when loading the model in web UI chat mode, the loading speed is twice as slow.

Expected behavior

Please upgrade the accelerate requirement to version 0.33.0 or let me know any possible mistakes that could cause the model loading speed to be slow under version 0.32.0 of accelerate.

Others

No response

@github-actions github-actions bot added the pending This problem is yet to be addressed label Aug 28, 2024
@hiyouga hiyouga added solved This problem has been already solved and removed pending This problem is yet to be addressed labels Aug 29, 2024
@hiyouga
Copy link
Owner

hiyouga commented Aug 29, 2024

fixed

yuwangnexusera pushed a commit to yuwangnexusera/LLaMA-Factory that referenced this issue Sep 5, 2024
yuwangnexusera pushed a commit to yuwangnexusera/LLaMA-Factory that referenced this issue Sep 5, 2024
yuwangnexusera pushed a commit to yuwangnexusera/LLaMA-Factory that referenced this issue Sep 5, 2024
yuwangnexusera pushed a commit to yuwangnexusera/LLaMA-Factory that referenced this issue Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

No branches or pull requests

2 participants