Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Mixture of Depth #3338

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Adding Mixture of Depth #3338

merged 2 commits into from
Apr 21, 2024

Conversation

mlinmg
Copy link
Contributor

@mlinmg mlinmg commented Apr 18, 2024

What does this PR do?

Add support for Mixture of Depths

Atm if qwen is loaded an error is thrown, wen the qwen issue is resolved I'll remove it

@hiyouga
Copy link
Owner

hiyouga commented Apr 18, 2024

cool, I'll review it tomorrow and I believe it can be merged soon

I wonder did you reproduce the qwen2 problem?

@mlinmg
Copy link
Contributor Author

mlinmg commented Apr 18, 2024

nope, fire days tho, I'll try it for longer tomorrow on runpod

@kostum123
Copy link

Is this going to merge anytime soon?

@hiyouga hiyouga self-requested a review April 21, 2024 10:00
@hiyouga
Copy link
Owner

hiyouga commented Apr 21, 2024

LGTM!

@hiyouga hiyouga merged commit d027378 into hiyouga:main Apr 21, 2024
1 check passed
@hiyouga hiyouga added the solved This problem has been already solved label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants