Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: splitted Dockerfile's CMD #3604

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: splitted Dockerfile's CMD #3604

merged 1 commit into from
May 7, 2024

Conversation

gaussian8
Copy link

@gaussian8 gaussian8 commented May 7, 2024 •
edited by hiyouga
Loading

What does this PR do?

Fixed Dockerfile's CMD.
When I build a docker image using current CMD and run, below error occurs.

/opt/nvidia/nvidia_entrypoint.sh: line 49: /usr/local/bin/llamafactory-cli webui: No such file or directory

So, I splitted CMD in Dockerfile, and it worked well.

Fixes #3603

Before submitting

@hiyouga hiyouga self-requested a review May 7, 2024 08:51
@hiyouga
Copy link
Owner

hiyouga commented May 7, 2024

LGTM!

@hiyouga hiyouga merged commit 6159acb into hiyouga:main May 7, 2024
1 check passed
@hiyouga hiyouga added the solved This problem has been already solved label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerfile CMD seems wrong
2 participants
@gaussian8 @hiyouga