Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some mllm features and try to incorporate Chinese-LLaVA-Med project #3651

Merged
merged 16 commits into from
May 11, 2024

Conversation

BUAADreamer
Copy link
Collaborator

@BUAADreamer BUAADreamer commented May 9, 2024

What does this PR do?

  1. add processor save to merge Lora with MLLM
  2. support full parameter fine-tuning of MLLM for deepspeed. We should set only mm_projector and lm requires_grad=True to be the same as LLaVA . A complete case can be found at Chinese-LLaVA-Med.
  3. incorporate a project Chinese-LLaVA-Med using the latest version of llama-factory to fine-tune a Chinese medical multimodal llm

Before submitting

@BUAADreamer BUAADreamer changed the title add mllm processor save to merge lora with mllm and try to incorporate Chinese-LLaVA-Med project add some mllm features and try to incorporate Chinese-LLaVA-Med project May 11, 2024
@hiyouga hiyouga self-requested a review May 11, 2024 14:42
@BUAADreamer
Copy link
Collaborator Author

BUAADreamer commented May 11, 2024

bug fix log (only for my own

  1. there is no hidden_size in config of llava-hf/llava-1.5-7b-hf. So patching hidden_size in config can satisfy ds3
  2. only qlora need autocast dtype, lora and full don't need

@hiyouga hiyouga merged commit 5da097f into hiyouga:main May 11, 2024
1 check passed
@hiyouga hiyouga added the solved This problem has been already solved label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants