Remove Redundant Environment Variable Usage #3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3653
With Gradio,
GRADIO_SERVER_PORTis by default 7860GRADIO_SHAREis by default None (0)So we don't really need these environment variables. Additionally, the
GRADIO_SERVER_PORTis causing issues when I already have another gradio app running on my machine since they use 7860 by default. (Gradio documentation about these variables here: https://www.gradio.app/docs/gradio/interface#interface-launch-arguments)By removing these manual presets and let Gradio handle the default values, the app works exactly the same but allows for more flexibility (automatically using next available port, such as 7861, when 7860 is already occupied by another app)
Before submitting