Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dataset sample num #3829

Merged
merged 9 commits into from
May 29, 2024
Merged

Add dataset sample num #3829

merged 9 commits into from
May 29, 2024

Conversation

seanzhang-zhichen
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

@hiyouga hiyouga added the pending This problem is yet to be addressed label May 20, 2024
@seanzhang-zhichen
Copy link
Contributor Author

fix conflict

@hiyouga hiyouga self-requested a review May 29, 2024 15:59
hiyouga
hiyouga approved these changes May 29, 2024
View reviewed changes
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes were made for neat implementation, now it can be safely merged. Thanks for adding this feature.

@hiyouga hiyouga merged commit 483eb47 into hiyouga:main May 29, 2024
1 check passed
@hiyouga hiyouga added solved This problem has been already solved and removed pending This problem is yet to be addressed labels May 29, 2024
@Katehuuh Katehuuh mentioned this pull request May 30, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanzhang-zhichen @hiyouga @15797939668