New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update model_args.py #4007

Merged

hiyouga merged 1 commit into hiyouga:main from xu-song:patch-3

Jun 3, 2024

Contributor

xu-song commented May 31, 2024

What does this PR do?

max-model-len is not the input length,
https://github.com/vllm-project/vllm/blob/a377f0bd5e1fa0ca069e3dbf28f4de5af64d0bb1/examples/fp8/README.md?plain=1#L87

Before submitting

Did you read the contributor guideline?


          Update model_args.py

dade2f0

hiyouga approved these changes

View reviewed changes

Owner

hiyouga commented Jun 3, 2024

LGTM!

hiyouga added the solved label

hiyouga merged commit 1539c72 into hiyouga:main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

solved