Add MANIFEST.in so requirements.txt is present in sdist #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensures that requirements.txt and the LICENSE file are correctly included in the source distribution (sdist) when the package is built (and eg; published to pypi).
Without this, we cannot build a conda package because a wheel cannot be successfully built from the current sdist (requirements.txt file is referenced by setup.py but is missing in the sdist).
Tested that this change correctly includes the requirements.txt file in the sdist using the procedure in the linked issue.
Fixes #4190
Before submitting