Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support vllm==0.5.0 #4234

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Support vllm==0.5.0 #4234

merged 1 commit into from
Jun 12, 2024

Conversation

kimdwkimdw
Copy link
Contributor

@kimdwkimdw kimdwkimdw commented Jun 12, 2024 •
edited
Loading

What does this PR do?

Fix #4238

vllm import changed today.

before from vllm.sequence import MultiModalData
after from vllm.multimodal import MultiModalData

Before submitting

@hiyouga hiyouga self-requested a review June 12, 2024 08:15
hiyouga
hiyouga approved these changes Jun 12, 2024
View reviewed changes
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 656b2bb into hiyouga:main Jun 12, 2024
1 check passed
@hiyouga hiyouga added the solved This problem has been already solved label Jun 12, 2024
@kimdwkimdw kimdwkimdw deleted the patch-1 branch June 12, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

training is broken with vllm==0.5.0
2 participants
@kimdwkimdw @hiyouga