Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-npu #4355

Merged
merged 8 commits into from
Jun 24, 2024
Merged

Add docker-npu #4355

merged 8 commits into from
Jun 24, 2024

Conversation

MengqingCao
Copy link
Contributor

What does this PR do?

Add dockerfile and docker-compose config file for Ascend NPU
cc @hiyouga

Before submitting

@hiyouga
Copy link
Owner

hiyouga commented Jun 18, 2024

Could you please update the README accordingly?

@hiyouga hiyouga added the pending This problem is yet to be addressed label Jun 18, 2024
@MengqingCao
Copy link
Contributor Author

Could you please update the README accordingly?

Sure

@MengqingCao
Copy link
Contributor Author

Could you please update the README accordingly?

done

  1. add docker-npu (Dockerfile and docker-compose.yml)
  2. move cuda docker to docker-cuda and tiny changes to adapt to the new path
@hiyouga hiyouga self-requested a review June 24, 2024 16:54
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did some necessary modifications and it can be safely merged.

@hiyouga hiyouga merged commit d0e6059 into hiyouga:main Jun 24, 2024
@hiyouga hiyouga added solved This problem has been already solved and removed pending This problem is yet to be addressed labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants