Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update torch-npu dependencies #4382

Merged
merged 1 commit into from
Jun 20, 2024
Merged

update torch-npu dependencies #4382

merged 1 commit into from
Jun 20, 2024

Conversation

MengqingCao
Copy link
Contributor

What does this PR do?

Numpy 2.0.0 版本发布，与 torch 2.1.0 不兼容，会导致以下错误：
image

该升级只影响 torch-npu 的默认安装使用，不影响最新版 torch

Before submitting

@hiyouga
Copy link
Owner

hiyouga commented Jun 20, 2024

I think it can generally be added to requirements.txt since numpy 2.0 breaks many dependencies

@MengqingCao
Copy link
Contributor Author

I think it can generally be added to requirements.txt since numpy 2.0 breaks many dependencies

That's okay! done

@hiyouga hiyouga self-requested a review June 20, 2024 02:18
hiyouga
hiyouga approved these changes Jun 20, 2024
View reviewed changes
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit a459624 into hiyouga:main Jun 20, 2024
1 check passed
@hiyouga hiyouga added the solved This problem has been already solved label Jun 20, 2024
@injet-zhou injet-zhou mentioned this pull request Jun 21, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MengqingCao @hiyouga