Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support flash-attn in Dockerfile #4461

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

hzhaoy
Copy link
Contributor

@hzhaoy hzhaoy commented Jun 25, 2024

What does this PR do?

flash-attn is mandatory for some models.
Uninstalling and then rebuilding flash-attn (following the installation) satisfied the requirement and fixed #4242 #4264 completely.

Before submitting

@hiyouga
Copy link
Owner

hiyouga commented Jun 26, 2024

Please take into consideration the GPU that does not support flash attn

ARG INSTALL_DEEPSPEED=false

@hiyouga hiyouga added the pending This problem is yet to be addressed label Jun 26, 2024
@hzhaoy hzhaoy force-pushed the feature/support-flash-attn branch from 242b691 to c88b1be Compare June 26, 2024 16:08
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 64b131d into hiyouga:main Jun 27, 2024
@hiyouga hiyouga added solved This problem has been already solved and removed pending This problem is yet to be addressed labels Jun 27, 2024
@hzhaoy hzhaoy deleted the feature/support-flash-attn branch June 27, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in launch using a docker image
2 participants