Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug when using pissa method with deepspeed #4580

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix bug when using pissa method with deepspeed #4580

merged 1 commit into from
Jun 27, 2024

Conversation

hzhaoy
Copy link
Contributor

@hzhaoy hzhaoy commented Jun 27, 2024 •
edited
Loading

What does this PR do?

Fix #4579

Before submitting

@hiyouga hiyouga self-requested a review June 27, 2024 16:44
@hiyouga hiyouga merged commit ef38daa into hiyouga:main Jun 27, 2024
@hiyouga hiyouga added the solved This problem has been already solved label Jun 27, 2024
@hzhaoy hzhaoy deleted the bugfix-deepspeed-pissa branch June 28, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise error when using pissa method with deepspeed
2 participants
@hzhaoy @hiyouga