Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit the process with the subprocess's return code when utilizing the CLI #4590

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Exit the process with the subprocess's return code when utilizing the CLI #4590

merged 1 commit into from
Jun 27, 2024

Conversation

injet-zhou
Copy link
Contributor

What does this PR do?

Associate the exit status of the parent process with that of its subprocesses.

Before submitting

@hiyouga hiyouga self-requested a review June 27, 2024 10:45
hiyouga
hiyouga approved these changes Jun 27, 2024
View reviewed changes
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 33ef6f4 into hiyouga:main Jun 27, 2024
@hiyouga hiyouga added the solved This problem has been already solved label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@injet-zhou @hiyouga