Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows command preview #4700

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix Windows command preview #4700

merged 1 commit into from
Jul 10, 2024
+4 −1

Conversation

marko1616
Copy link
Contributor

@marko1616 marko1616 commented Jul 6, 2024 •
edited
Loading

What does this PR do?

In windows mutiline command should like

llamafactory-cli train `
    --stage sft `
    --do_train True `

Before submitting

@marko1616
Update utils.py
e056252 
In windows mutiline command should like
command --arg1 xxx `
--arg2 xxx `
@marko1616 marko1616 changed the title Update utils.py Windows command preview fix Jul 6, 2024
@marko1616
Copy link
Contributor Author

image

@marko1616 marko1616 changed the title Windows command preview fix Fix Windows command preview Jul 6, 2024
@hiyouga hiyouga self-requested a review July 10, 2024 05:42
hiyouga
hiyouga approved these changes Jul 10, 2024
View reviewed changes
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga added the solved This problem has been already solved label Jul 10, 2024
@hiyouga hiyouga merged commit 555194e into hiyouga:main Jul 10, 2024
1 check passed
@marko1616 marko1616 deleted the patch-1 branch July 19, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marko1616 @hiyouga