Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cuda Dockerfile #4781

Merged
merged 3 commits into from
Jul 13, 2024
Merged

Fix cuda Dockerfile #4781

merged 3 commits into from
Jul 13, 2024

Conversation

hzhaoy
Copy link
Contributor

@hzhaoy hzhaoy commented Jul 11, 2024 •
edited
Loading

What does this PR do?

Fix #4779
Fix #4780

Before submitting

@hiyouga hiyouga self-requested a review July 13, 2024 14:13
hiyouga
hiyouga approved these changes Jul 13, 2024
View reviewed changes
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 5da54de into hiyouga:main Jul 13, 2024
1 check passed
@hiyouga hiyouga added the solved This problem has been already solved label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when inference using vllm with multi-gpu FlashAttn error when launching from docker image
2 participants
@hzhaoy @hiyouga