Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "split" as suffix in eval task name #4821

Merged
merged 2 commits into from
Jul 15, 2024
Merged

add "split" as suffix in eval task name #4821

merged 2 commits into from
Jul 15, 2024

Conversation

codemayq
Copy link
Collaborator

What does this PR do?

  1. add "split" as suffix in eval task name
  2. remove "split" param in data_args.py

Before submitting

@codemayq
1. change the task name format
645211d 
2. delete split param in data_args.py
@hiyouga hiyouga self-requested a review July 15, 2024 14:55
hiyouga
hiyouga approved these changes Jul 15, 2024
View reviewed changes
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 38bc411 into hiyouga:main Jul 15, 2024
1 check failed
@hiyouga hiyouga added the solved This problem has been already solved label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codemayq @hiyouga