Feat optimizer #5095
Merged
Feat optimizer #5095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, upper: without adam-mini, lower: with adam-mini
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix: Rename the
optimzertooptimizerFeat: #4696
https://github.com/zyushun/Adam-mini
Use follow command to install adam_mini.
Now you can train the model with
--use_adammini Truenow.This optimizer still has a lot of room for improvement, but as of now, it is not as good as Unsloth.
But if you can't use Unsloth, it will be a good way to replace adawm_torch.
zyushun/Adam-mini#11
Before submitting