Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lr not change #5163

Merged
merged 1 commit into from
Aug 19, 2024
Merged

fix lr not change #5163

merged 1 commit into from
Aug 19, 2024

Conversation

liu-zichen
Copy link
Contributor

@liu-zichen liu-zichen commented Aug 13, 2024

What does this PR do?

Fixes #5060 (issue)
The optimizer with lr_scheduler was not added to trainer.

Before submitting

Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@hiyouga hiyouga merged commit da335d4 into hiyouga:main Aug 19, 2024
1 check passed
@hiyouga hiyouga added the solved This problem has been already solved label Aug 19, 2024
@liu-zichen liu-zichen deleted the fix_ppo_optim branch August 20, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PPO全参数训练lr scheduler不起作用,loss先下降后一直增大,reward也在下降
2 participants