Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mllm api #5237

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Fix mllm api #5237

merged 5 commits into from
Aug 27, 2024

Conversation

marko1616
Copy link
Contributor

@marko1616 marko1616 commented Aug 22, 2024 •
edited
Loading

What does this PR do?

In ChatModel.achat should input image: Optional["NDArray"] but in following code it return PIL.Image directly.

LLaMA-Factory/src/llamafactory/api/chat.py

Line 115 in 36039b0

image = Image.open(image_path).convert("RGB")

Before submitting

hiyouga
hiyouga requested changes Aug 27, 2024
View reviewed changes
src/llamafactory/api/chat.py Outdated Show resolved Hide resolved
@marko1616 marko1616 requested a review from hiyouga August 27, 2024 03:36
@hiyouga hiyouga merged commit dbe886a into hiyouga:main Aug 27, 2024
1 check passed
@marko1616 marko1616 deleted the patch-1 branch August 27, 2024 04:25
@hiyouga hiyouga added the solved This problem has been already solved label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyouga hiyouga hiyouga approved these changes

Assignees
No one assigned
Labels
solved This problem has been already solved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marko1616 @hiyouga