Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch size of map function in the preprocessed dataset #5323

Merged

Conversation

naem1023
Copy link
Contributor

@naem1023 naem1023 commented Sep 2, 2024

What does this PR do?

Add batch size arguments for map function in the _get_preprocessed_dataset.

  • Some of machine can't accept the default batch size(1000) of dataset map function.
  • Therefore, users should be able to modify the batch size of the map function through external arguments.

Before submitting

@naem1023 naem1023 changed the title feat: add batch size of map function in the preprocessed dataset Add batch size of map function in the preprocessed dataset Sep 2, 2024
@hiyouga hiyouga added the pending This problem is yet to be addressed label Sep 2, 2024
@hiyouga hiyouga self-requested a review September 4, 2024 14:09
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 8f441c2 into hiyouga:main Sep 4, 2024
1 check passed
@hiyouga hiyouga added solved This problem has been already solved and removed pending This problem is yet to be addressed labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants