fix(lru-redis): ensure tests are valid

hokify · Mar 9, 2020 · fe1a9f9 · fe1a9f9
1 parent 12356d8
commit fe1a9f9
Show file tree

Hide file tree

Showing 4 changed files with 246 additions and 4 deletions.
diff --git a/storages/lru-redis/package-lock.json b/storages/lru-redis/package-lock.json
diff --git a/storages/lru-redis/package.json b/storages/lru-redis/package.json
@@ -50,8 +50,9 @@
     "lru-cache": "^5.1.1"
   },
   "devDependencies": {
+    "ioredis-mock": "^4.19.0",
     "@types/ioredis": "^4.14.8",
     "@types/lru-cache": "^5.1.0"
   },
-  "gitHead": "179ca6def52cbf51e09fc22c09f7313d6356105b"
+  "gitHead": "12356d80b38a7b841fa377840f13c37fbe3c9cd3"
 }
diff --git a/storages/lru-redis/src/LRUWithRedisStorage.ts b/storages/lru-redis/src/LRUWithRedisStorage.ts
@@ -27,7 +27,7 @@ export class LRUWithRedisStorage implements StorageTypes {
       }
     }
 
-    return localCache;
+    return localCache || undefined;
   }
 
   public async setItem(key: string, content: any): Promise<void> {

diff --git a/storages/lru-redis/test/lru.storage.test.ts b/storages/lru-redis/test/lru.storage.test.ts
@@ -1,7 +1,18 @@
 import * as Assert from "assert";
-import LRUStorage from "../src";
+import LRURedisStorage from "../src";
 
-const storage = new LRUStorage({});
+
+// @ts-ignore
+import * as RedisMock from "ioredis-mock";
+
+const MockedRedis = new RedisMock({
+  host: "host",
+  port: 123,
+  password: "pass"
+});
+
+
+const storage = new LRURedisStorage({}, () => MockedRedis);
 
 describe("LRUStorage", () => {
   it("Should add cache item correctly", async () => {
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,7 +27,7 @@ export class LRUWithRedisStorage implements StorageTypes { @@
           }
         }
-        return localCache;
+        return localCache || undefined;
       }
       public async setItem(key: string, content: any): Promise<void> {
@@ Expand Down @@