fix(ttl): allow overwriting ttls

hokify · Aug 30, 2020 · ff24982 · ff24982
1 parent 7d2e5b8
commit ff24982
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/storages/lru-redis/src/LRUWithRedisStorage.ts b/storages/lru-redis/src/LRUWithRedisStorage.ts
@@ -36,10 +36,10 @@ export class LRUWithRedisStorage implements AsynchronousCacheType {
     return localCache || undefined;
   }
 
-  public async setItem(key: string, content: any): Promise<void> {
+  public async setItem(key: string, content: any, options?: { ttl?: number }): Promise<void> {
     this.myCache.set(key, content);
     if (this.options?.maxAge) {
-      await this.redis().setex(key, this.options.maxAge, JSON.stringify(content));
+      await this.redis().setex(key, options?.ttl || this.options.maxAge, JSON.stringify(content));
     } else {
       await this.redis().set(key, JSON.stringify(content));
     }

diff --git a/storages/redisio/package.json b/storages/redisio/package.json
@@ -54,5 +54,5 @@
     "@types/ioredis": "^4.17.2",
     "ioredis-mock": "^4.21.2"
   },
-  "gitHead": "179ca6def52cbf51e09fc22c09f7313d6356105b"
+  "gitHead": "7d2e5b85914c7a6e54edad434b0fcbae37c484b4"
 }
diff --git a/storages/redisio/src/redisio.storage.ts b/storages/redisio/src/redisio.storage.ts
@@ -13,14 +13,18 @@ export class RedisIOStorage implements AsynchronousCacheType {
     return finalItem || undefined;
   }
 
-  public async setItem(key: string, content: any): Promise<void> {
+  public async setItem(key: string, content: any, options?: { ttl?: number }): Promise<void> {
     if (typeof content === "object") {
       content = JSON.stringify(content);
     } else if (content === undefined) {
       await this.redis().del(key);
       return;
     }
-    await this.redis().set(key, content);
+    if (options?.ttl) {
+      await this.redis().setex(key, options.ttl, content);
+    } else {
+      await this.redis().set(key, content);
+    }
   }
 
   public async clear(): Promise<void> {

diff --git a/storages/redisio/test/redis.storage.test.ts b/storages/redisio/test/redis.storage.test.ts
@@ -10,7 +10,7 @@ const MockedRedis = new RedisMock({
   password: "pass"
 });
 
-const storage = new RedisIOStorage({}, MockedRedis);
+const storage = new RedisIOStorage(() => MockedRedis);
 
 describe("RedisIOStorage", () => {
   it("Should clear Redis without errors", async () => {