Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow Python3.11 as it's not currently supported due to aiohttp dependency #87858

Closed
wants to merge 2 commits into from

Conversation

dtrodrigues
Copy link
Contributor

@dtrodrigues dtrodrigues commented Feb 10, 2023

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Per #84611 (comment), Python 3.11 isn't currently supported, so refelct it in pyproject.toml

@dtrodrigues dtrodrigues requested a review from a team as a code owner February 10, 2023 18:13
@home-assistant home-assistant bot added bugfix cla-needed small-pr PRs with less than 30 lines. labels Feb 10, 2023
@home-assistant
Copy link

Hi @dtrodrigues

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@bdraco
Copy link
Member

bdraco commented Feb 10, 2023

aiohttp is almost sorted out aio-libs/aiohttp#7180

@dtrodrigues
Copy link
Contributor Author

If a release of aiohttp is coming soon, then no need for this PR. I got bitten since HomeAssistant told me support for my version of Python was deprecated, so I installed 3.11 which failed due to the above error, and then I had to install 3.10.

@frenck
Copy link
Member

frenck commented Feb 11, 2023

While this PR seems like a good idea, it will actually limit to work on Phyton 3.11 in Home Assistant development.

Therefore, I am going to friendly decline this PR.

../Frenck

@frenck frenck closed this Feb 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants