Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Discrepancy on “threshold” calculation and --io_phase option #26

Open
hocinemahni opened this issue Jan 29, 2025 · 0 comments
Labels
bug Something isn't working triage Triage new issue

Comments

@hocinemahni
Copy link

What happened?

Hi,

I would like to highlight two points that, in my view, may require clarification or correction.:

  1. Threshold Calculation
    The documentation and comments mention that the threshold is computed as “mean + std” of the intervals between I/O phases. However, in the code inside merge_overlapping_io_phases() (in dxt.py ), it appears to be simply the average (mean) of those intervals, without adding the standard deviation. Could you confirm which is the intended formula?

  2. --io_phase Option Not Recognized
    When attempting to generate the I/O phase plots via -i or --io_phase flags, DXT Explorer returns an “unrecognized argument” error. It looks like the command-line parser includes an --io_phase option, but the installed version or Docker image does not recognize it. Is there a recommended approach or updated version for generating I/O phase plots ?
    Any clarification on these points would be really helpful. Thanks in advance, and keep up the great work!

What did you expect to happen?

Hi,

I would like to highlight two points that, in my view, may require clarification or correction.:

  1. Threshold Calculation
    The documentation and comments mention that the threshold is computed as “mean + std” of the intervals between I/O phases. However, in the code inside merge_overlapping_io_phases() (in dxt.py ), it appears to be simply the average (mean) of those intervals, without adding the standard deviation. Could you confirm which is the intended formula?

  2. --io_phase Option Not Recognized
    When attempting to generate the I/O phase plots via -i or --io_phase flags, DXT Explorer returns an “unrecognized argument” error. It looks like the command-line parser includes an --io_phase option, but the installed version or Docker image does not recognize it. Is there a recommended approach or updated version for generating I/O phase plots ?
    Any clarification on these points would be really helpful. Thanks in advance, and keep up the great work!

Version

0.1

Relevant log output

dxt-explorer 1.3 (Aug 17, 2022)
@hocinemahni hocinemahni added bug Something isn't working triage Triage new issue labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Triage new issue
Projects
None yet
Development

No branches or pull requests

1 participant