Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right analog for touch controls. #12182

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Conversation

LunaMoo
Copy link
Collaborator

@LunaMoo LunaMoo commented Jul 18, 2019

Not to be confused with #9859 which this doesn't fulfill despite that issue name as it's a request for mapping other controls for the analog which this doesn't.

It only add's a right analog to be used as a proper right analog. This is useful for HD remasters and even more for games patched(ie through CWCheat) to get real right analog controls for example Metal Gear Solid Peace Walker or Ghost in the Shell Stand Alone Complex.

If set to visible, resetting touch location to defaults will move face keys up and place right analog under reflecting dpad and left analog stick.

Screenshot_2019-07-18-04-05-42-596_org ppsspp ppssppluna

@unknownbrackets
Copy link
Collaborator

I think this is a good thing, but I'm slightly concerned that it'll lead to confused users when it doesn't work in 99% of games unless there's some way to tell them it needs cheats or there's mapping or something...

-[Unknown]

@LunaMoo
Copy link
Collaborator Author

LunaMoo commented Jul 18, 2019

Made it clear on the visibility screen. Right analog touch is disabled by default, so anyone who will want to activate it will see that it doesn't do anything in PSP games.

@LunaMoo LunaMoo added the Input/Controller Input and controller issues label Jul 18, 2019
@LunaMoo LunaMoo added this to the v1.9.0 milestone Jul 18, 2019
@hrydgard
Copy link
Owner

Still a little concerned by the wording, as it implies that PPSSPP plays things other than PSP games (which strictly is true, but for most normal purposes isn't). Maybe it should only appear at all when playing remasters and patched game?

@marosis
Copy link

marosis commented Jul 18, 2019

So what just use right analog stick as, triangle= Y Up, cross= Y down, square= X left and circle= X right. This is really good for FPS games

@LunaMoo
Copy link
Collaborator Author

LunaMoo commented Jul 18, 2019

Ok, changed to "(not used by most games)".
Can't really make it to "only patched games" since patches can be applied by different ways some not detectable in any easy way and maintaining some kind of list would be a chore. At most I could hide touch right analog completely through ini-only setting since remasters only use it as d-pad alternative while right analog patches are even less popular than fps patches and I don't see people even willing to learn how to make them.

As for requests about mapping digital controls to touch analog as stated on the start this PR has nothing to do with that. I'm also not intrested in doing it at all since for me the benefit of touch analog stick exists only when it's used at much larger size than my thumb which is really useful to gain better control over sensitivity with true analog control, but that's actually something that most PSP games doesn't really support even for left stick. There might be people for which this is positive improvement, but to me personally it would at most be the opposite and would rather replace "digital analog stick" into 4 digital touch buttons since analog used digitally typically has to use some high threeshold and requires bigger and more tiresome movement for exactly same digital actions.

@ghost
Copy link

ghost commented Jul 24, 2019

Right Analog doesn't work in Monster Hunter 3rd HD 🤔
Screenshot_2019-07-25-06-36-47
Screenshot_2019-07-25-06-36-56
Im using ppsspp luna edition 😅
@LunaMoo Do I need to use cwcheat for MH3rd HD to make right analog work?

@Saramagrean
Copy link
Contributor

It work for me without cheat. :)

In the village can not rotate the camera angle, will only be used when playing in quests.

@ghost
Copy link

ghost commented Jul 25, 2019

@Saramagrean thanks for feedback now I can really enjoy playing Monster Hunter 3rd HD via PPSSPP :3

@hrydgard
Copy link
Owner

Decided I can accept the new wording. Merging.

@hrydgard hrydgard merged commit 734658b into hrydgard:master Jul 25, 2019
@LunaMoo LunaMoo deleted the touchRA branch July 25, 2019 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Input/Controller Input and controller issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants