Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add camera support for linux (V4L2) #12580

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Conversation

Florin9doi
Copy link
Contributor

No description provided.

Core/HLE/sceKernel.cpp Outdated Show resolved Hide resolved
Core/HLE/sceUsbCam.cpp Outdated Show resolved Hide resolved
Core/HW/Camera.h Outdated Show resolved Hide resolved
@@ -1409,12 +1409,6 @@ public boolean processCommand(String command, String params) {
// Only keep the screen bright ingame.
window.clearFlags(WindowManager.LayoutParams.FLAG_KEEP_SCREEN_ON);
}
} else if (command.equals("event")) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is called from __UsbCamShutdown now

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not this Android mCameraHelper, as far as I can tell skimming the code...

@hrydgard
Copy link
Owner

I'm fine with this now, except still unsure about that Android camerahelper thingy..

@Florin9doi
Copy link
Contributor Author

event#exitgame was used to deallocate camera resources when a game is closed.
In this patch, the same thing is done by:
__UsbCamShutdown>>Camera::stopCapture>>System_SendMessage("stopVideo")

@hrydgard
Copy link
Owner

I see! Sorry I missed that.

@hrydgard hrydgard merged commit 7db5471 into hrydgard:master Jan 16, 2020
@Florin9doi Florin9doi deleted the v4l2b branch January 17, 2020 04:01
@unknownbrackets unknownbrackets added this to the v1.10.0 milestone Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants