Replace the "Test Analogs" screen with a new screen that lets you directly try the settings. #14596
Conversation
…ectly try the settings.
…tput to the left next to the controls.
| ConfigSetting("AnalogSensitivity", &g_Config.fAnalogSensitivity, 1.0f, true, true), | ||
| ConfigSetting("AnalogIsCircular", &g_Config.bAnalogIsCircular, true, true, true), | ||
| ConfigSetting("AnalogSensitivity", &g_Config.fAnalogSensitivity, 1.1f, true, true), | ||
| ConfigSetting("AnalogIsCircular", &g_Config.bAnalogIsCircular, false , true, true), |
There was a problem hiding this comment.
Isn't it circular on most platforms? Won't this give a lot of people diagonal problems?
-[Unknown]
There was a problem hiding this comment.
It has a circular-ish range on many platforms, but the circular transform used here is a bit extreme and feels weird testing it with the new visualization. Generally it works better to just increase sensitivity (scale) and clamp to a square.
There was a problem hiding this comment.
Okay, got it.
-[Unknown]
| void Draw(UIContext &dc) override; | ||
| std::string DescribeText() const override { return ""; } | ||
| std::string DescribeText() const override { return "Analog Stick View"; } |
There was a problem hiding this comment.
This has a title_, so any description should include the title, and possibly values. I was trying to use this semantically as an accessibility tree. Using it as a developer name for the control is more the purpose of DescribeLog().
I'd previously intentionally made it blank because the associated text was separate from this graphical representation, so this view had on separate and useful textual meaning. Not sure if that's still true.
I realize it's not really exposed in a useful way to any accessibility tree at this point, and you probably wouldn't search it, but just wanted to explain the purpose of the method as I'd considered it.
-[Unknown]
There was a problem hiding this comment.
Oh right, this was just a driveby change and I didn't reflect on the real purpose. Thanks for clarifying!
ghost
mentioned this pull request
Also thinking about renaming some of those settings and there are some further possible UX improvements, but let's get this in first.