Add breakpoint conditions to GE debugger #15974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, not used, but indicates info about each GE register.
unknownbrackets
force-pushed
the
debugger-gecond
branch
from
d887375 to
f14e49a
Compare
|
Really cool and should be useful for quite some GPU debugging scenarios. Let's get it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't have them yet for prim, texture, target, etc. type breakpoints but at least for addresses and register changes.
More conditions would be nice - for example on screen-space vertex coords for a prim, and for actions like jump/etc. (currently not possible in UI.) I also think it could be useful to have log-only cases. That said, this is a good start on better GE breakpoints.
I created a little syntax (maybe could be used to "assemble" commands too...) but it's currently esoteric. For example, you could set a breakpoint on blend mode and use the condition:
(data & 0xF0) == (10 << 4) && blendfixb == 0x112233. In the future I kinda want to add fields so you could dodata.dstfactor == 10 && vtype.through == 1or similar. Note it'sdatabecause that's the incoming value (blendmodeis unchanged as yet.)It might be nice to add constants too as "symbols" but that might get even more esoteric (example:
data.dstfactor == GE_DSTBLEND_FIXBordata.dstfactor == data.dstfactor.fixedor something.)GECmdFormatcaptures pretty much all the bit patterns there are, but I might think about changing it based on fields. Not sure.-[Unknown]