softgpu: Cull verts outside post-viewport Z #16480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't have removed this before, points are still culled when depth clamp is off and throughmode is off. Fixes Crazy Taxi graphics glitches.
hrydgard
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't have removed this before, points are still culled when depth clamp is off and throughmode is off.
Fixes Crazy Taxi 2 graphics glitches, see #16131. Had removed this in #14820 (0b73c1c) overzealously. Also checked accuracy better, it's definitely at >= 65536.0.
Ran through a bunch of previously fixed frame dumps to make sure I didn't miss anything... hopefully.
Also, not dealt with here... some of my tests related to this are suggesting that through-mode depth is not clamped at the vertex level to 0/FFFF, but rather that it interpolates and clamps at the fragment level. So maybe clamping it within the vertex reader is wrong, after all...
-[Unknown]