D3D9: Support old-style user clip planes #16615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes negative Z issues on D3D9 in many cases, such as hrydgard#14168 and hrydgard#16574, but only when clip planes are supported.
5 tasks
I think it does actually happen, but we don't do it in the shader, so let's not do it here.
|
Also, here's GL: master...unknownbrackets:ppsspp:gl-clip-planes Needs GPU_USE_ACCURATE_DEPTH forced on (unless you have clamp, which seems unlikely on GL2), but it's not working on NVIDIA. I think because glClipPlane is removed in GL4 and I seem to only get a GL4 context back no matter what I do. Anyway, this could potentially be helpful on older Apple (that only support GL2) or something, but maybe not worth it. -[Unknown] |
hrydgard
approved these changes
Dec 18, 2022
|
Nice and simple enough - maybe even 14.1? |
|
I do think it'd be pretty safe for 1.14.x, but I suppose you never know. It's not something that was newly broken in 1.14.x or anything. -[Unknown] |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes negative Z issues on D3D9 in many cases, such as #14168 and #16574, but only when clip planes are supported. Fixes #16615.
Something similar is doable on GL2 (may help older Apple), but I'm having trouble being able to test it, so I'll create a separate PR...
-[Unknown]